Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed Muir to muir #79

Merged
merged 4 commits into from
Mar 31, 2023
Merged

changed Muir to muir #79

merged 4 commits into from
Mar 31, 2023

Conversation

shimwell
Copy link
Member

OpenMc 0.13.3 is nearly out and the Muir has ben replaced with muir as described in issue #71

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #79 (ed2b47a) into main (cd00546) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files           7        7           
  Lines         216      216           
=======================================
  Hits          208      208           
  Misses          8        8           
Impacted Files Coverage Δ
openmc_plasma_source/point_source.py 100.00% <100.00%> (ø)
openmc_plasma_source/ring_source.py 100.00% <100.00%> (ø)
openmc_plasma_source/tokamak_source.py 97.19% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shimwell
Copy link
Member Author

tests are passing, I think this is ready to merge, but might want to wait for the conda release of openmc

@shimwell
Copy link
Member Author

openmc 0.13.3 is released on conda, so I think this is ready to merge. Let me know if you have any objections @RemDelaporteMathurin

if not I shall merge in next week

@RemDelaporteMathurin
Copy link
Member

@shimwell no objections!

@shimwell shimwell merged commit 0917dc9 into main Mar 31, 2023
@shimwell shimwell deleted the muir_api_update branch November 28, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants