From 159f6e3d6e4b8af5266c4e833360a39add71ffbe Mon Sep 17 00:00:00 2001
From: Jan Martin Keil <jan-martin.keil@uni-jena.de>
Date: Wed, 25 Sep 2024 23:27:10 +0200
Subject: [PATCH] refactoring

---
 .../PropertyComparisonProcessor.java          | 24 ++++++++-----------
 1 file changed, 10 insertions(+), 14 deletions(-)

diff --git a/abecto-core/src/main/java/de/uni_jena/cs/fusion/abecto/processor/PropertyComparisonProcessor.java b/abecto-core/src/main/java/de/uni_jena/cs/fusion/abecto/processor/PropertyComparisonProcessor.java
index cfa80f0..65b6607 100644
--- a/abecto-core/src/main/java/de/uni_jena/cs/fusion/abecto/processor/PropertyComparisonProcessor.java
+++ b/abecto-core/src/main/java/de/uni_jena/cs/fusion/abecto/processor/PropertyComparisonProcessor.java
@@ -118,12 +118,11 @@ protected void setAspectDatasets() {
         datasetPairs = ResourcePair.getPairsOf(datasets);
         datasetTupels = ResourceTupel.getTupelsOf(datasets);
         outputMetaModelByDataset = getOutputMetaModels(datasets);
-        correspondingResourcesByDataset = new HashMap<>();
-        resourcesByNonDistinctValueByDatasetByVariable = getMapOfResourcesByValueByDatasetByVariable();
-        resourcesByDistinctValueByDatasetByVariable = getMapOfResourcesByValueByDatasetByVariable();
+        resourcesByNonDistinctValueByDatasetByVariable = createMapOfResourcesByValueByDatasetByVariable();
+        resourcesByDistinctValueByDatasetByVariable = createMapOfResourcesByValueByDatasetByVariable();
     }
 
-    protected Map<String, Map<Resource, Map<RDFNode, Set<Resource>>>> getMapOfResourcesByValueByDatasetByVariable() {
+    protected Map<String, Map<Resource, Map<RDFNode, Set<Resource>>>> createMapOfResourcesByValueByDatasetByVariable() {
         Map<String, Map<Resource, Map<RDFNode, Set<Resource>>>> map = new HashMap<>();
         for (String variable : variables) {
             Map<Resource, Map<RDFNode, Set<Resource>>> resourcesByValueByDataset = new HashMap<>();
@@ -168,7 +167,6 @@ protected <M extends Count<ResourcePair>> void setZeroForVariablesCoveredByDatas
     }
 
     protected void loadResourcesOfAspect() {
-        unprocessedResourcesByDataset.clear();
         for (Resource dataset : datasets) {
             loadResourcesOfAspectAndDataset(dataset);
         }
@@ -185,7 +183,7 @@ protected void compareValuesOfCorrespondingResources() {
 
     protected void compareValuesOfCorrespondingResources(List<Resource> correspondingResources) {
         setCorrespondingResourcesByDataset(correspondingResources);
-        removeCorrespondingResourcesFromUncoveredResources();
+        removeFromUnprocessedResources(correspondingResources);
 
         loadNonDistinctValues();
         calculateDistinctValues();
@@ -196,7 +194,7 @@ protected void compareValuesOfCorrespondingResources(List<Resource> correspondin
         reportDeviationsAndOmissions();
     }
 
-    protected void setCorrespondingResourcesByDataset(List<Resource> correspondingResources) {
+    protected void setCorrespondingResourcesByDataset(Collection<Resource> correspondingResources) {
         for (Resource dataset : datasets) {
             Set<Resource> correspondingResourcesOfDataset = new HashSet<>(correspondingResources);
             correspondingResourcesOfDataset.retainAll(unprocessedResourcesByDataset.get(dataset));
@@ -204,16 +202,14 @@ protected void setCorrespondingResourcesByDataset(List<Resource> correspondingRe
         }
     }
 
-    protected void removeCorrespondingResourcesFromUncoveredResources() {
-        for (Resource dataset : correspondingResourcesByDataset.keySet()) {
-            Set<Resource> uncoveredResourcesOfDataset = unprocessedResourcesByDataset.get(dataset);
-            Set<Resource> coveredResourcesOfDataset = correspondingResourcesByDataset.get(dataset);
-            uncoveredResourcesOfDataset.removeAll(coveredResourcesOfDataset);
+    protected void removeFromUnprocessedResources(Collection<Resource> correspondingResources) {
+        for (Set<Resource> unprocessedResourcesOfDataset : unprocessedResourcesByDataset.values()) {
+            unprocessedResourcesOfDataset.removeAll(correspondingResources);
         }
     }
 
     protected void loadNonDistinctValues() {
-        resetResourcesByNonDistinctValueByDatasetByVariable();
+        clearValues(resourcesByNonDistinctValueByDatasetByVariable);
 
         Set<Resource> datasetsOfCorrespondingResources = correspondingResourcesByDataset.keySet();
 
@@ -223,7 +219,7 @@ protected void loadNonDistinctValues() {
         }
     }
 
-    protected void resetResourcesByNonDistinctValueByDatasetByVariable() {
+    protected void clearValues(Map<String, Map<Resource, Map<RDFNode, Set<Resource>>>> resourcesByNonDistinctValueByDatasetByVariable) {
         for (Map<Resource, Map<RDFNode, Set<Resource>>> resourcesByNonDistinctValueByDataset : resourcesByNonDistinctValueByDatasetByVariable.values()) {
             for (Map<RDFNode, Set<Resource>> resourcesByNonDistinctValue : resourcesByNonDistinctValueByDataset.values()) {
                 resourcesByNonDistinctValue.clear();