Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Make withFontLoading HOC compatible with Styletron's withStyle #108

Open
dhdemerson opened this issue Aug 22, 2018 · 0 comments
Open

Make withFontLoading HOC compatible with Styletron's withStyle #108

dhdemerson opened this issue Aug 22, 2018 · 0 comments
Assignees

Comments

@dhdemerson
Copy link

Type of issue

Feature Request

Description

Fusion.js uses Styletron for managing component styles. Composing styles in Styletron is accomplished using withStyle, withStyleDeep, and withTransform functions. Ideally this plugin would be compatible with those functions to allow composition of styles where fonts are being loaded.

Current behavior

If withStyle is called on a styled component wrapped in a withFontLoading HOC a TypeError is produced.

Expected behavior

withStyle should be able to create styled components wrapped by a withFontLoading HOC with font loading from the base component.

OR

Styled component composition with font loading should be addressed in the documentation describing workarounds, patterns, or general guidance.

Steps to reproduce

N/A

Your environment

  • fusion-plugin-font-loader-react version: 1.0.3

  • Node.js version (node --version): Any

  • npm version (npm --version): Any

  • Operating System: Any

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants