Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cargo test riot-rs-esp as well #426

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ROMemories
Copy link
Collaborator

Description

Issues/PRs references

Open Questions

Change checklist

  • I have cleaned up my commit history and squashed fixup commits.
  • I have followed the Coding Conventions.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.

@ROMemories ROMemories added CI arch Architecture support labels Sep 18, 2024
@kaspar030
Copy link
Collaborator

@ROMemories where are we with this?

@ROMemories
Copy link
Collaborator Author

where are we with this?

So that one is annoying, because the esp-hal crate selects a runtime crate (*-rt) based on the processor architecture (riscv32 or xtensa):

https://github.com/esp-rs/esp-hal/blob/0dc8dcf8e2f25bf0c26f41a1cb2bbcb98433bceb/esp-hal/Cargo.toml#L66-L70

If none is selected then we get the errors the CI is currently failing with ("unresolved import esp_riscv_rt"); however, if we set a processor architecture using --target=riscv32imac-unknown-none-elf for instance, then we get the following error:

error[E0463]: can't find crate for `test`

error: `#[panic_handler]` function required, but not found

For more information about this error, try `rustc --explain E0463`.
error: could not compile `riot-rs-esp` (lib test) due to 2 previous errors

I'm not sure what the right move would be here; should we try to patch esp-hal to select the runtime crate based on the already existing riscv and xtensa features (in your fork)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch Architecture support CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants