Highlights the default room that was set in the settings #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninjahoahong
approved these changes
Jul 17, 2017
ninjahoahong
added a commit
that referenced
this pull request
Jul 25, 2017
* Permission requests (#47) * Handle the deprecated of DigitalClock * Remove unused imports * Highlights the default room that was set in the settings (#42) * Layouts for 7-inch tablets. * Using non-resource calendars (#44) * Extends API to use non-resource calendars for happy non-Google-Apps users. * Changes preferences retrieval and setting to a centralised preference manager * Enables walkthrough when user opens app for the first time. User can select account, whether he syncs non-resource calendars, visible rooms, default room. * Implements error handling when going through wizard. User will be redirect to the settings page if errors happen during the process. * Adds new options to settings page, reloads proxy after Google Account would have been changed * Fixes an issue that the TrafficLight would close automatically after 45 seconds * Show setup wizard if all account removed when the user is already in Lobby * Hot fixed cannot compile * Feature/check permission (#51) * Adds Activity to check permissions and gitignore * Configs xml files and gradle properties * Changes code indentation to 4 tabs * Only request permissions on API > 23 * Ignore .idea files * Change description of the resources for the reservator (#52) * Change description of the resources for the reservator * Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #39
Just a small disclaimer: If there is no room capacity set, the icon will seem just a bit unaligned. I'd be interested in redesigning the
LobbyActivityanyways though with a separate pull request (also replacing the deprecatedDigitalClock).