Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document usage #4

Open
xurizaemon opened this issue Oct 8, 2018 · 2 comments
Open

Document usage #4

xurizaemon opened this issue Oct 8, 2018 · 2 comments

Comments

@xurizaemon
Copy link
Contributor

xurizaemon commented Oct 8, 2018

I haven't tested the "usage" instructions submitted in #1 , and in CiviCRM chat I thought I saw Pete say you have to turn off logging (otherwise this extension will create new records as it tries to clean up?).

But in the code I see you disable logging before doing the cleanup, so ...

Is it necessary to turn off CiviCRM's change logging before using this? If so, that should be documented.

@jitendrapurohit
Copy link
Collaborator

Is it necessary to turn off CiviCRM's change logging before using this? If so, that should be documented.

Nope - that is not necessary as you've seen we've handled this in the code. But maybe, we should handle it more appropriately. It seems it enables the logging even if the site was having it disabled before the job execution. I'll test that soon and update.

Thanks

@adixon
Copy link

adixon commented Dec 13, 2018

Yes, it'll turn on logging if you start with it off. Which is a pretty big deal on a large install.

But otherwise - nice extension, just what I was going to write myself until I found yours, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants