Skip to content
This repository has been archived by the owner on Apr 30, 2021. It is now read-only.

improve create target --seed #15

Open
kjk opened this issue Aug 2, 2019 · 2 comments
Open

improve create target --seed #15

kjk opened this issue Aug 2, 2019 · 2 comments

Comments

@kjk
Copy link
Contributor

kjk commented Aug 2, 2019

  1. It should also accept .zip files as it's more widely supported than tar.gz

  2. It should validate that the file given is in valid format (.tar.gz or .zip) before uploading it

@kjk
Copy link
Contributor Author

kjk commented Aug 2, 2019

Also validate the directory structure inside the archive is correct.

Can I just archive top-level files (say, foo.html, bar.html) or do they have to be in a directory (like corpus/foo.html and corpus/bar.html)?

Is the directory name significant?

@yevgenypats
Copy link
Contributor

Actually it must be top-level files without a directory inside. Agree that some sort of validation is needed. Also agree on the .zip though it will need some tweaks on the backend so let's leave this Issue open for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants