Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest fvwm seems to do away with negative numbered desks. #1045

Closed
ileGITimo opened this issue Jul 7, 2024 · 4 comments
Closed

Latest fvwm seems to do away with negative numbered desks. #1045

ileGITimo opened this issue Jul 7, 2024 · 4 comments
Labels
skip:changelog Issue/PR should skip CHANGELOG type:bug Something's broken!

Comments

@ileGITimo
Copy link
Contributor

Mentioned in issue #1044, opening as separate issue.

Latest code (as of sometime last week) does away with negative numbered desks.

As someone that has mostly used pagers with desks -1 to 1 or -2 to 2, ever since there were desks, and have lots of StartsOnPage with negative desks, I feel lost.

@ileGITimo ileGITimo added the type:bug Something's broken! label Jul 7, 2024
@ThomasAdam
Copy link
Member

I can appreciate that. However, the EWMH specification does say there shouldn't be any negative desk numbers.

It is technically a breaking change, but I would argue that there's very few users of negative desks.

@ThomasAdam ThomasAdam closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
@ThomasAdam ThomasAdam added the skip:changelog Issue/PR should skip CHANGELOG label Jul 8, 2024
@somiaj
Copy link
Collaborator

somiaj commented Jul 10, 2024

Note, I broke negative desks in the pager due to some other changes (it was not intentional), as I didn't realize negative desks could be used (since I haven't seen it before and as mentioned the EWMH spec only supports non-negative desks).

In short fvwm3 still supports negative desks, it is only FvwmPager that no longer shows them. It wasn't intentional to cause this breakage, but it isn't worth fixing (fix is non trivial now), and it is probably best you stop using negative desks (since other applications that follow the EWMH spec may also get confused if you put windows on negative desks).

@ileGITimo
Copy link
Contributor Author

I've been using fvwm for over 30 years. As soon as there were desks I always had multiple desks, centered around 0. My desktop is Nx1, usually paging from -1 to +1, sometimes I need to switch back and forth to/from -2 to +2 by restarting the pager in some of my monitors. Getting rid of the negative windows is both, simply done by editing a few config files, and incredible hard to retrain my 30 year old brain muscle memory.

@ileGITimo
Copy link
Contributor Author

In short fvwm3 still supports negative desks,

This is not the case. Changes that added "Desk N" to the Move command, in both fvwm/move_resize.c and fvwm/update.c, do not handle negative desks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip:changelog Issue/PR should skip CHANGELOG type:bug Something's broken!
Projects
None yet
Development

No branches or pull requests

3 participants