Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor error in example #62

Open
nataliyaskrypnyuk opened this issue Apr 27, 2023 · 3 comments
Open

Minor error in example #62

nataliyaskrypnyuk opened this issue Apr 27, 2023 · 3 comments

Comments

@nataliyaskrypnyuk
Copy link

Hi Francis,

in the example "Generate blue noise samples on a mesh separated by approximately 0.01 times the bounding box diagonal" you have the same code as for "Generate 10000 samples on a mesh with poisson disk samples", namely f_i, bc = pcu.sample_mesh_poisson_disk(v, f, n, 10000)

@fwilliams
Copy link
Owner

Oops! Thanks for pointing this out. Sounds like a copy paste error 😄

@nataliyaskrypnyuk
Copy link
Author

I have actually noticed one more thing: pcu.sample_mesh_random sometimes throws out some crazy high number for the facet id output ;-( But that happens very rare, so I call it again with random_seed set to get different sampling every time ;-) Thanks for your library!

@fwilliams
Copy link
Owner

If ever you have a seed and an input that reproduces this, please upload it so I can debug! Thanks for using the library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants