-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more local data #3
Comments
Perhaps every Foxbox should be using a unique and sufficiently strong random ID for registration. This enables a few nice features on the registration server side:
|
UniqueID == risk of tracking ! I'd like to avoid that if possible. Being somewhat more aggressive with the re-registration from the client and eviction on the server should mitigate your first 2 points in practice (eg. every 5 minutes). |
We might want to deploy some type of API key or signed client-cert which allows the Box to connect to http://knilxof.org:4242/register?ip=192.168.0.42, so that not just anybody can pretend to be a Box. |
Also, what about registering what's my public name if registered against any proxy solution we could have. (Until the dynamic dns solution is in place) |
Yes, we need that. Right now the Box registers its local IP address. Instead, it should register its public-local DNS host (whether dynamic or not). I'll prepare a PR for this. |
Update: @arcturus mentioned on irc that he wants to keep the interaction-less flow as an option, even after gate 1. We can however harden this server by requiring the Box to authenticate when registering (with a client cert for instance). Another hardening option would be white-listing/black-listing CORS origins. For instance, the registration server instance could have an interface where an app developer registers the origin of their web app; if we see abuse, we revoke API access for that origin. |
The box should also send the port number it's listening on, and maybe the local hostname in addition to the local ip.
The text was updated successfully, but these errors were encountered: