Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic PopUp should not close when tapped inside #5358

Closed
andydotxyz opened this issue Jan 3, 2025 Discussed in #5340 · 3 comments
Closed

Basic PopUp should not close when tapped inside #5358

andydotxyz opened this issue Jan 3, 2025 Discussed in #5340 · 3 comments

Comments

@andydotxyz
Copy link
Member

Discussed in #5340

Originally posted by typenoob December 27, 2024
Hi, I want to make a popup which would be closed when tap on the backdrop but remain on the screen if tap inside of it. The NewPopUp or NewModalPopUp method does not satisfy my requirement perfectly. Is there any solution for it conveniently? Appreciate for any help!

@andydotxyz andydotxyz added this to the E fixes (v2.5.x) milestone Jan 3, 2025
@dweymouth
Copy link
Contributor

Interestingly, it seems like it was once intentional behavior to hide the popup when tapped - https://github.com/fyne-io/fyne/blob/develop/widget/popup.go#L80. I do think this is wrong though and we should remove it to achieve the behavior described in this issue.

@dweymouth
Copy link
Contributor

dweymouth commented Jan 4, 2025

oh, interesting, removing that prevents the popup from dismissing at all... I guess the popup actually covers the whole window even though it doesn't look like it. This will be harder to fix then

Edit: nevermind, wasn't that hard of a fix :)

@dweymouth
Copy link
Contributor

Fixed on develop for next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants