-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to package structure #12
Comments
Seems like it will be tidyverbs :). |
I agree... on the other hand, it's hard to think of a what a hypothetical parallel-universe tidyverbs: Animate the Verbs of the Tidyverse. or tidyverbs: Verbs of the Tidyverse, Animated. Regardless, it does seem like there's going to be a clear winner in the poll 😄 |
- Import packages from tidyverse - Set global imports in zzzz-package.R - Import pipe and tidyeval - Update authors - Downgrade version to 0.0.1.9000 - Change license to MIT - TODO: Internal package qualifications still needed, e.g. dplyr::row_numbers()
I really like the tidyexplainer name. But I guess its not really in the poll :) |
I agree, let’s think on it for a day or two. The name change will happen as soon as it’s settled. The plan with the pkg branch on the other hand is to treat that like the master for the package until the package is solid (more or less feature complete) and then move that branch to master. |
One drawback of using |
That's a great point and one I hadn't thought of. For me, that convinces me against I think I'm now much more on the side of Btw, here are the other Tidy CRAN Packages
|
Once the dust settles on the twitter poll...
Rename this repo. It seems that everything will redirect but may need to investigate/resolve if not.
I'd like to merge #10 into a new
pkg
branch that we can use for the package development. This way we can push fixes and improvements there while leaving the current animations and documentation on the master branch. Once everything is ready to go with the package, we can merge to master.To facilitate communication, I'd like to still use feature branches and PRs for any major feature additions or updates. Minor bugfixes can be pushed directly to
pkg
. Branch names likepkg-add-filter-animation
are great. Let me know if there are any questions with this workflow.I'll handle getting #10 into the
pkg
branch in this repo once it's ready.The text was updated successfully, but these errors were encountered: