-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs should be permitted, maybe even mandatory. #73
Comments
Does the IUC standards currently actually talk about tabs versus spaces? I had a search but couldn't find anything. I note Python has the PEP8 coding standard and ecosystem of tools like code-formatter black which use spaces not tabs. Which file formats do you have in mind here? XML and JSON? Everything? Everything except Python? |
It states Use 4 spaces for indentation under the best practice file. Which has sometimes been treated as a requirement for tool submissions rather than simply a "best practice".
I'd be already happier if this PR resolved with accepting tabs in addition to 4 spaces, as long as the author is consistent. |
Ah, I searched for terms like tabs, not indentation. I would have no objection to recommending tabs for indentation in the Galaxy tool XML files. I have embraced black for auto formatting my Python code, and would happily do the same for XML. |
Oh, and your compromise of tabs or 4-spaces in XML as long as consistent is good too. |
Likewise, it's made things a lot easier. Ok, between the thumbs up and your comments, I'll make a PR proposing the change then! |
While still allowing spaces, and just promoting consistency. Fixes #73
They're better for accessibility:
I've never understood IUC's demand for them (they're "best practice" but somehow also 100% mandatory), and I think we should change this. Clients can set tabs to any width they personally prefer, you can have 2 or 8 or 4, and folks that want them for accessibility reasons will finally have them.
(sorry to restart this old argument.)
The text was updated successfully, but these errors were encountered: