From 34be7a641e61fc8445a4bffbc8d32358911e2be6 Mon Sep 17 00:00:00 2001 From: Matthias Bernt Date: Tue, 19 Oct 2021 13:05:07 +0200 Subject: [PATCH] move fix for empty options to https://github.com/galaxyproject/galaxy/pull/12733 --- lib/galaxy/tool_util/linters/inputs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/galaxy/tool_util/linters/inputs.py b/lib/galaxy/tool_util/linters/inputs.py index 85857df1269d..c973e1b72636 100644 --- a/lib/galaxy/tool_util/linters/inputs.py +++ b/lib/galaxy/tool_util/linters/inputs.py @@ -164,7 +164,7 @@ def lint_inputs(tool_xml, lint_ctx): # lint statically defined options if any(['value' not in option.attrib for option in select_options]): lint_ctx.error(f"Select parameter [{param_name}] has option without value") - if len(set([option.text.strip() for option in select_options if option.text is not None])) != len(select_options): + if len(set([option.text.strip() for option in select_options])) != len(select_options): lint_ctx.error(f"Select parameter [{param_name}] has multiple options with the same text content") if len(set([option.attrib.get("value") for option in select_options])) != len(select_options): lint_ctx.error(f"Select parameter [{param_name}] has multiple options with the same value")