From 37a50cc39bc0820a03c04956c23cc62c66b42cc2 Mon Sep 17 00:00:00 2001 From: Nicola Soranzo Date: Thu, 25 Apr 2024 18:16:37 +0100 Subject: [PATCH] Fix integration tests for Celery 5.4.0 Fix the following error: ``` ____ TestCeleryUserRateLimitIntegrationNoLimit.test_mock_pass_user_id_task _____ self = def test_mock_pass_user_id_task(self): > self._test_mock_pass_user_id_task(2, 3, self._user_rate_limit) test/integration/test_celery_user_rate_limit.py:161: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = num_users = 2, num_calls = 3, tasks_per_user_per_sec = 0.0 for user_results in results.values(): last_task_end_time = start_time for result in user_results: > if result.date_done > last_task_end_time: E TypeError: can't compare offset-naive and offset-aware datetimes test/integration/test_celery_user_rate_limit.py:110: TypeError ``` Also https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow is deprecated since Python 3.12 . --- test/integration/test_celery_user_rate_limit.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/integration/test_celery_user_rate_limit.py b/test/integration/test_celery_user_rate_limit.py index 61f2f207735d..b9b832c5cddc 100644 --- a/test/integration/test_celery_user_rate_limit.py +++ b/test/integration/test_celery_user_rate_limit.py @@ -83,7 +83,7 @@ def _test_mock_pass_user_id_task(self, num_users: int, num_calls: int, tasks_per expected_duration = secs_between_tasks_per_user * (num_calls - 1) expected_duration_lbound = expected_duration - 4 expected_duration_hbound = expected_duration + 4 - start_time = datetime.datetime.utcnow() + start_time = datetime.datetime.now(datetime.timezone.utc) timer = ExecutionTimer() # Invoke test task num_calls times for each user results: Dict[int, List[AsyncResult]] = {}