Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error parsing tool metadata from bio.tools #16445

Closed
kysrpex opened this issue Jul 24, 2023 · 1 comment
Closed

Error parsing tool metadata from bio.tools #16445

kysrpex opened this issue Jul 24, 2023 · 1 comment

Comments

@kysrpex
Copy link
Contributor

kysrpex commented Jul 24, 2023

Describe the bug
Parsing bio.tools data for tool metadata is broken, probably because of research-software-ecosystem/content#fd9ed50 or research-software-ecosystem/content#7b40d92 (sorry, we are using this feature just since last night). The keys "function" and "topic" do not exist any longer for many tools. Thus, such tools fail to load.

[...]
Error reading tool from path: toolshed.g2.bx.psu.edu/repos/devteam/get_flanks/077f404ae1bb/get_flanks/get_flanks.xml
[...]
exception KeyError: 'function'

[...]
Error reading tool from path: toolshed.g2.bx.psu.edu/repos/iuc/b2btools_single_sequence/b694a77ca1e8/b2btools_single_sequence/b2btools_single_sequence.xml
[...]
exception KeyError: 'topic'

Galaxy Version and/or server at which you observed the bug
Galaxy Version: 23.0.4.dev0
Commit: 6af19176966a6e379ca84c406e90d856c45c3abe (from the usegalaxy-eu/galaxy fork)

To Reproduce
Steps to reproduce the behavior:

  1. Start Galaxy (web handlers, e.g. /opt/galaxy/venv/bin/gunicorn galaxy.webapps.galaxy.fast_factory:factory() --timeout 600 --pythonpath lib -k galaxy.webapps.galaxy.workers.Worker -b unix:/opt/galaxy/mutable-data/gunicorn_2.sock)
  2. Messages such as Error reading tool from path: toolshed.g2.bx.psu.edu/repos/devteam/get_flanks/077f404ae1bb/get_flanks/get_flanks.xml show up in the logs.
  3. The tool's page shows the message "Loading tool toolshed.g2.bx.psu.edu/repos/devteam/get_flanks/get_flanks21/1.0.0 failed: Could not find tool with id 'toolshed.g2.bx.psu.edu/repos/devteam/get_flanks/get_flanks1/1.0.0'. "

Expected behavior
The tool loads and can be used, which is a better outcome than not loading the tool at all, even if the EDAM annotations become unavailable.

Screenshots
grafik

Additional context
We created usegalaxy-eu#179 to quickly address the problem because a lot of important tools were missing. I would like to suggest that whatever fix you decide to apply, you apply the changes on top of the latest commit from such PR, so that we have a clean history and no merge conflicts when syncing back the upstream fix. Please be aware also of the remark at the end of the PR: you can merge this branch all the way back to Galaxy 21.09 where the code involved in the issue was introduced.

@mvdbeek
Copy link
Member

mvdbeek commented Jul 26, 2023

This should be fixed in #16449, thanks @kysrpex !

@mvdbeek mvdbeek closed this as completed Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants