[24.2] Handle isatools dependency #19582
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in committers channel, there's a dependency conflict preventing publishing the galaxy-data package to pypi. The
isa-rwval
dependency is currently installed from a github fork due to the incompatibility of the original package with numpy 2.0 (see ISA-tools/isa-rwval#17 for context). However, such dependencies cannot be uploaded to PyPI.The proposed solution is to remove the isatools dependency from the data package and wrap the import in datatypes in a try block.
Another option would be to publish the fork on PyPI.
(Thanks to @nsoranzo for proposed approach)
TODO:
License