Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Celery when running via gravity #38

Open
mvdbeek opened this issue Mar 9, 2022 · 5 comments
Open

Enable Celery when running via gravity #38

mvdbeek opened this issue Mar 9, 2022 · 5 comments

Comments

@mvdbeek
Copy link
Member

mvdbeek commented Mar 9, 2022

I don't think we can switch this to true within Galaxy just now, but we know in gravity that Celery is available, so we could set GALAXY_CONFIG_ENABLE_CELERY_TASKS=true in the supervisor config.

@nsoranzo
Copy link
Member

nsoranzo commented Mar 9, 2022

I think activating this via the GALAXY_CONFIG_ environment variable may confuse the admins, since it overrides what's in galaxy.yml .

@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 9, 2022

GALAXY_CONFIG_* should not override values in galaxy.yml, that would be GALAXY_CONFIG_OVERRIDE_*

@nsoranzo
Copy link
Member

nsoranzo commented Mar 9, 2022

Right, but it would still enable it if it's left commented in galaxy.yml

@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 9, 2022

Yes, that is the idea. I prefer this over rewriting the Galaxy config, and otherwise we'll have to come up with some other solution to checking if celery is available and functional.

@natefoo
Copy link
Member

natefoo commented Mar 14, 2022

I get the point, an admin may be confused why the commented-out-default is not actually the applied setting in this case. Gravity could print a warning that it's doing this I guess? But it would also hopefully be fairly obvious from the fact that it starts celery processes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants