Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: use Fuzz.oneOfValues #17

Open
miniBill opened this issue Jul 31, 2024 · 1 comment · May be fixed by #26
Open

Improvement: use Fuzz.oneOfValues #17

miniBill opened this issue Jul 31, 2024 · 1 comment · May be fixed by #26
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@miniBill
Copy link 

I think I can fix this. Here is my proposal:

146| ascDescFuzzer =
147|     Debug.todo ""
148|     Fuzz.oneOf [ Fuzz.constant SQLite.Types.Asc, Fuzz.constant SQLite.Types.Desc ]
148|

The code could be simplified using Fuzz.oneOfValues
@gampleman gampleman added enhancement New feature or request good first issue Good for newcomers labels Oct 3, 2024
@gampleman
Copy link
Owner

Can be fixed in src/Internal/Builtin/Fuzzer.elm by adding a special case to customType. PRs welcome!

miniBill added a commit to miniBill/elm-review-derive that referenced this issue Dec 14, 2024
@miniBill
Use Fuzz.oneOfValues when possible
7aa9e1b 
Fixes gampleman#17
@miniBill miniBill linked a pull request Dec 14, 2024 that will close this issue
Open
@miniBill miniBill changed the title Improvement: use Fuzz.listOfValues Improvement: use Fuzz.oneOfValues Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Fuzz.oneOfValues when possible miniBill/elm-review-derive
2 participants
@gampleman @miniBill