From 74809724d5e670f48246296ea864ee52bdef1a8b Mon Sep 17 00:00:00 2001 From: Alexander Hulpke Date: Thu, 7 Dec 2023 11:25:16 -0700 Subject: [PATCH] FIX: Ensure NewmanInfinityTest works and does not run into a error message because of generator number in the PQ. Also some comments. --- lib/grpfp.gi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/grpfp.gi b/lib/grpfp.gi index d20913b630..7a6f0fa3b2 100644 --- a/lib/grpfp.gi +++ b/lib/grpfp.gi @@ -5525,9 +5525,10 @@ local GO,q,d,e,b,r,val,agemo,ngens; ngens:=32; repeat ngens:=ngens*8; - q:=PQuotient(G,p,2,ngens); + q:=PQuotient(G,p,2,ngens:noninteractive); until q<>fail; q:=Image(EpimorphismQuotientSystem(q)); + # factor out G^p q:=ShallowCopy(PCentralSeries(q,p)); if Length(q)=1 then Error("Trivial

quotient"); @@ -5535,9 +5536,12 @@ local GO,q,d,e,b,r,val,agemo,ngens; if Length(q)=2 then Add(q,q[2]); # maximal quotient is abelian, second term is trivial fi; + d:=LogInt(Index(q[1],q[2]),p); if p=2 then + # This case is taken from the book by Johnson, as Newman's paper only + # treats odd n. e:=LogInt(Index(q[2],q[3]),p); Info(InfoFpGroup,1,b," generators, ",r," relators, p=",p,", d=",d," e=",e); q:=r-b+d;