upstream?

[dimpase]

What does prevent this from being upstreamed?

[olexandr-konovalov]

Could you please clarify what does "upstreamed" mean?

[dimpase]

making GAP formula available on the main Homebrew repo, naturally.

[dimpase]

e.g. Pari/GP is there:
https://formulae.brew.sh/formula/pari#default

[olexandr-konovalov]

Ok (I had two other interpretations of "upstreamed" in mind, none of them matching yours :)

It was there before, in homebrew-science, but then after its deprecation we were recommended to maintain own tap.

[dimpase]

I don't know who recommended this, why not just make a PR to put it into the main repo? How is GAP more niche than Pari/GP, so that it should not be in the main repo ?

[olexandr-konovalov]

Can't find where that was recommended: IIRC it was suggested as an alternative in https://github.com/Homebrew/homebrew-science/pull/6500, but can't be sure, and the link is not working any more. That was already after I've attempted Homebrew/homebrew-core#21928, which was not merged, so whoever will try this again, please look at the feedback at that PR first.

[dimpase]

as soon as GAP gets `make install` - which that PR promised in 4.10, it'd become trivial...

[fingolfin]

Yeah, as soon as someone puts in the work to make it possible and resolve all the icky little bits and details, and also cleans this formula up to match Homebrew's quality requirement, it will indeed be trivial...

[fingolfin]

Oh and on that PR I did not promise to add make install support for 4.10 -- I stated it as a plan; like so many plans, it didn't succeed. Although we are a lot closer shrug

[dimpase]

Oops, I grew up with 5-year Plans blasting from every mass media orifice, which of course were more, much more than promises, so I probably am irreparably brain-damaged and take plans as promises, sorry.

[olexandr-konovalov]

For the record, two other conjectures of how should I interpret the verb "upstreamed" were:
a) update this repository to GAP 4.11.1.
b) make this a standard GAP distribution updated and announced together with the release (so part of the main GAP repository?)

(a) is in TODOs, and I 'm happy to go without (b) in either forms.

[fingolfin]

To quote the Homebrew documentation:

We frown on authors submitting their own work unless it is very popular.

Take that as you will... shrug

[dimpase]

I think it's popular enough to be considered for inclusion (and it'd reduce traffic on the support and other help lists). The usual question, of course, is what packages to bundle, and how to arrange for the rest of the packages to be installable.