Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-e2e-provider-local.sh: Use skaffold instead of make docker-images and kind load docker-image #446

Open
ialidzhikov opened this issue Jul 22, 2024 · 0 comments
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension

Comments

@ialidzhikov
Copy link
Member

How to categorize this issue?

/area networking
/kind enhancement

What would you like to be added:

make docker-images
docker tag europe-docker.pkg.dev/gardener-project/public/gardener/extensions/networking-calico:latest networking-calico-local:$version
kind load docker-image networking-calico-local:$version --name gardener-local
mkdir -p $repo_root/tmp
cp -f $repo_root/example/controller-registration.yaml $repo_root/tmp/controller-registration.yaml
yq -i e "(select (.helm.values.image) | .helm.values.image.tag) |= \"$version\"" $repo_root/tmp/controller-registration.yaml
yq -i e '(select (.helm.values.image) | .helm.values.image.repository) |= "docker.io/library/networking-calico-local"' $repo_root/tmp/controller-registration.yaml
kubectl apply --server-side --force-conflicts -f "$repo_root/tmp/controller-registration.yaml"
to be changed to something like https://github.com/gardener/gardener-extension-registry-cache/blob/c924400d255feba1266d5f943a2e64ec625ff210/hack/ci-e2e-kind.sh#L36-L40.

make docker-images pulls the golang image from docker.io defined in the Dockerfile. With skaffold this is likely avoided.

Why is this needed:
To prevent dockerhub rate limit issues for e2e executions in prow.

@gardener-robot gardener-robot added area/networking Networking related kind/enhancement Enhancement, improvement, extension labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

No branches or pull requests

2 participants