Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how the update automation works #47

Open
fwilhe opened this issue Nov 29, 2024 · 0 comments
Open

Document how the update automation works #47

fwilhe opened this issue Nov 29, 2024 · 0 comments

Comments

@fwilhe
Copy link
Member

fwilhe commented Nov 29, 2024

Because it came up in a conversation

We have to manually create a comment to map the ci workflow run to the pr we create as part of the automation as we do it here. This is due to the fact that github on purpose does not trigger workflow runs for prs that are created in the automation as documented here.

The sad thing is that this does not give us this nice integration of ci results in the pr, as you can see in this manually created pr

Screenshot 2024-11-29 at 10 51 11

It rather looks like this (0 checks, which is not true, but the mapping is missing):

Screenshot 2024-11-29 at 10 51 51

As a workaround I've made it so we at least comment the workflow run in the pr. This seems to work reliably from what I can tell so far. It's not perfect but it's the best thing I could come up with so far.

Screenshot 2024-11-29 at 10 52 29

Leaving this issue open as documentation, and maybe as a reminder to look for a better solution in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant