Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add caching for all api calls #113

Open
gardenofwine opened this issue Dec 28, 2012 · 2 comments
Open

Add caching for all api calls #113

gardenofwine opened this issue Dec 28, 2012 · 2 comments
Labels
Functionality MEDIUM

Comments

@gardenofwine
Copy link
Owner

A caching mechanism could be added so users would be able to view the info they have viewed in the past, even when they are offline.

there is a mechanism for it, to pass the 'diskCache' key in the parameter for getAPIData; however, there is no consideration for when the cache might be filled... at that point the caching mechanism won't work anymore.
@romansky
Copy link
Contributor

working on it

@romansky romansky mentioned this issue Dec 28, 2012
Merged
@romansky
Copy link
Contributor

fix in #115

@gardenofwine gardenofwine reopened this Dec 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Functionality MEDIUM
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gardenofwine @romansky