Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I use "live-restore" option with current systemd templates? #691

Open
fitz123 opened this issue May 26, 2017 · 5 comments
Open

How can I use "live-restore" option with current systemd templates? #691

fitz123 opened this issue May 26, 2017 · 5 comments

Comments

@fitz123
Copy link

fitz123 commented May 26, 2017

Currently it's not possibly to use --live-restore docker option because puppet service template has hardcoded daemon dependency: https://github.com/garethr/garethr-docker/blob/master/templates/etc/systemd/system/docker-run.erb#L7

So any time docker daemon is restarted - it restarts all containers too. We want to avoid this behavior and be able to upgrade daemon itself and restart it with no containers affection

Is it possible to exclude "docker.service" dependency or be able to overwrite this?

Thank you and regards.

@mendhak
Copy link

mendhak commented Feb 6, 2018

Were you able to work around this issue? I'm looking to get a live-restore option somehow as well

@fitz123
Copy link
Author

fitz123 commented Feb 6, 2018

I'm using custom template as a docker-run.erb

@mendhak
Copy link

mendhak commented Feb 6, 2018

Hi do you mean a template to put values into /etc/docker/daemon.json? I was thinking of doing something like that and putting the live-restore in there.

@fitz123
Copy link
Author

fitz123 commented Feb 6, 2018

that one too, of course. But it already are configurable and you can update it whatever you want. the main struggle (and the point of this issue) is https://github.com/garethr/garethr-docker/blob/master/templates/etc/systemd/system/docker-run.erb#L7
which gives you no chance to restart docker service without getting all containers restarting by SystemD

@mendhak
Copy link

mendhak commented Feb 6, 2018

Ah thanks for the update and clarification this is very useful to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants