Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refreshonly attribute to docker::image #556

Open
aleshav opened this issue Jul 18, 2016 · 0 comments · May be fixed by #702
Open

Add refreshonly attribute to docker::image #556

aleshav opened this issue Jul 18, 2016 · 0 comments · May be fixed by #702

Comments

@aleshav
Copy link

aleshav commented Jul 18, 2016

We are building our docker image using Dockerfile which copies couple of config files created using Puppet. It would be great if in case any of these config files changes and sends a refresh to the docker::image class, it would rebuild the container image.
Currently this can be (kind of) done by setting ensure to 'latest', but it executes the "docker build" every time, even when there is no change in config files and pollutes the Puppet output in when using --noop.

I think the solution would be to add a refreshonly attribute to the docker::image class, by default set to 'false', and pass this to the Exec["echo 'Update of ${image_arg} complete'"] block which runs in case ensure is set to 'latest'.

@omerlh omerlh linked a pull request Jul 9, 2017 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant