Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review notes #11

Open
malteish opened this issue Sep 19, 2022 · 0 comments
Open

review notes #11

malteish opened this issue Sep 19, 2022 · 0 comments

Comments

@malteish
Copy link

malteish commented Sep 19, 2022 •
edited
Loading

  • had to use new ethers.Wallet(...) because Wallet was not defined
  • unable to use the line Gashawk.fromSigner(...) because of ReferenceError: Gashawk is not defined
  • there is no mention of the workshop-repo in the sdk-repo
  • workshop: in import { HelloGashawk__factory } from "../typechain";, had to replace ../typechain with typechain
  • so far unable to use gashawk in my sample project, which was set up as javascript-hardhat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@malteish