Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate removal of base64 encoding in Handle...Message functions #29

Open
mostafa opened this issue Apr 8, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mostafa
Copy link
Member

mostafa commented Apr 8, 2024

Currently all the JSON-marshaled messages are encoded to base64 and then these messages are decoded from base64 and marshalled back to JSON. This takes time and has performance overhead. On the other hand, different message types might have different fields that might be bytes (binary value). This should be investigated to see if we can remove this encoding/decoding altogether and pass the data as v1.Struct (as a JSON object) without all the hassle.

@mostafa mostafa added the enhancement New feature or request label Apr 8, 2024
@mostafa mostafa added this to the v0.1.x milestone Apr 8, 2024
@mostafa mostafa self-assigned this Apr 8, 2024
@mostafa mostafa moved this from 🆕 New to 📋 Backlog in Plugins Public Roadmap Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant