Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a logger wrapper for use in the consumer #35

Open
mostafa opened this issue May 28, 2024 · 0 comments
Open

Implement a logger wrapper for use in the consumer #35

mostafa opened this issue May 28, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@mostafa
Copy link
Member

mostafa commented May 28, 2024

As explained in this review comment, if the consumer is going to be used in GatewayD as part of gatewayd-io/gatewayd#472, it should use the zerolog logger, however when used in the plugins it should use the hclog logger. Upon implementing this feature, it should be investigated whether using the same consume in GatewayD is the way to move forward or GatewayD should have and implement its own consumer (that uses zerolog).

Resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant