Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image in article body #19

Closed
pr0xity opened this issue Oct 4, 2024 · 2 comments · Fixed by #25
Closed

Image in article body #19

pr0xity opened this issue Oct 4, 2024 · 2 comments · Fixed by #25
Assignees
Milestone

Comments

@pr0xity
Copy link
Contributor

pr0xity commented Oct 4, 2024

We need a way to show a image using the id of the image

Images from the article body looks like this
<embed embedtype=\"image\" format=\"fullwidth\" id=\"7\" alt=\"TG-promo-6\"/>

@github-project-automation github-project-automation bot moved this to Ideas / Inbox in TG.no Oct 4, 2024
@pr0xity
Copy link
Contributor Author

pr0xity commented Oct 4, 2024

Also need to have a look at the main image output in the json from https://dev.tg.no/api/v2/news/12/
Currently gives

    "main_image": {
        "url": "/media/images/20220113211909-302b6da0-me.2e16d0ba.fill-100x100.jpg",
        "full_url": "https://dev.tg.no/media/images/20220113211909-302b6da0-me.2e16d0ba.fill-100x100.jpg",
        "width": 100,
        "height": 100,
        "alt": "Gamer over shoulder picture"
    }

But we want a bigger image not 100x100...

[Editors note: https://github.com//issues/21]

@mfyll
Copy link
Member

mfyll commented Oct 8, 2024

Issue closed, this is already working 👍 💯 🥇
EDIT: And #25 also solves this in an even better way, good job @niccofyren

@mfyll mfyll closed this as completed Oct 8, 2024
@github-project-automation github-project-automation bot moved this from Next up to Done in TG.no Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants