Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/stretchr/testify to enable suite usage #447

Closed
thatgim opened this issue Aug 13, 2024 · 1 comment
Closed

Update github.com/stretchr/testify to enable suite usage #447

thatgim opened this issue Aug 13, 2024 · 1 comment
Assignees
Labels
dependencies Managing dependencies
Milestone

Comments

@thatgim
Copy link

thatgim commented Aug 13, 2024

Hi!

I just noticed I can't use github.com/stretchr/testify/suite with httpexpect because in v1.5.0 Suite.T() returns a custom wrapper type TestingT.
https://pkg.go.dev/github.com/stretchr/[email protected]/suite#Suite.T
In the latest version this is fixed/better because it just returns a regular *testing.T.
https://pkg.go.dev/github.com/stretchr/[email protected]/suite#Suite.T

@gavv
Copy link
Owner

gavv commented Mar 3, 2025

Thanks for report, bumped testify to 1.6.0, where this change was first introduced: c251d4b

Closing, feel free to reopen if needed.

@gavv gavv closed this as completed Mar 3, 2025
@gavv gavv added the dependencies Managing dependencies label Mar 3, 2025
@gavv gavv added this to the v2 milestone Mar 3, 2025
@gavv gavv self-assigned this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Managing dependencies
Projects
None yet
Development

No branches or pull requests

2 participants