Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider checking for the existence of files at time of download #50

Open
osrf-migration opened this issue Jan 25, 2019 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@osrf-migration
Copy link

Original report (archived issue) by Nate Koenig (Bitbucket: Nathan Koenig).


Summary

Potentially check if a file exists during the model:// to file:// conversion in LocalCache.cc::FixPaths. See https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-fuel-tools/pull-requests/82/ready-integration-with-ign-gazebo/activity#comment-89120270

Describe alternatives you've considered

We could report an error message, leave the model:// tag in it's original state, leave the file://, or do nothing.

Things to consider:

  1. Should ign-fuel-tools take on the role of check for the existence of files, or is that the job of a downstream application?

  2. Error messages of this type tend to clutter the console, and are not useful for downstream applications. Returning error codes are better.

  3. There could be dependencies on other resources. So, a model that is converted from "model://" to "file://" may rely on addtional resources that will be downloaded in the future.

@osrf-migration osrf-migration added minor enhancement New feature or request labels Apr 15, 2020
@chapulina chapulina removed the minor label May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants