You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We could report an error message, leave the model:// tag in it's original state, leave the file://, or do nothing.
Things to consider:
Should ign-fuel-tools take on the role of check for the existence of files, or is that the job of a downstream application?
Error messages of this type tend to clutter the console, and are not useful for downstream applications. Returning error codes are better.
There could be dependencies on other resources. So, a model that is converted from "model://" to "file://" may rely on addtional resources that will be downloaded in the future.
The text was updated successfully, but these errors were encountered:
Original report (archived issue) by Nate Koenig (Bitbucket: Nathan Koenig).
Summary
Potentially check if a file exists during the
model://
tofile://
conversion in LocalCache.cc::FixPaths. See https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-fuel-tools/pull-requests/82/ready-integration-with-ign-gazebo/activity#comment-89120270Describe alternatives you've considered
We could report an error message, leave the
model://
tag in it's original state, leave thefile://
, or do nothing.Things to consider:
Should ign-fuel-tools take on the role of check for the existence of files, or is that the job of a downstream application?
Error messages of this type tend to clutter the console, and are not useful for downstream applications. Returning error codes are better.
There could be dependencies on other resources. So, a model that is converted from "model://" to "file://" may rely on addtional resources that will be downloaded in the future.
The text was updated successfully, but these errors were encountered: