Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for getting Joint limits #2664

Open
mogumbo opened this issue Nov 1, 2024 · 1 comment
Open

Add API for getting Joint limits #2664

mogumbo opened this issue Nov 1, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted We accept pull requests!

Comments

@mogumbo
Copy link

mogumbo commented Nov 1, 2024

Desired behavior

Add methods Joint::VelocityLimits, Joint::EffortLimits, Joint::PositionLimits for getting limits, corresponding to the existing setter methods.

Alternatives considered

I looked at getting these values from the ECM using components::JointVelocityLimitsCmd, components::JointEffortLimitsCmd, and components::JointPositionLimitsCmd. However, their headers all contain comments such as "It is expected that the physics plugin reads this component and sets the limit to the dynamics engine. After setting it, the data of this component will be cleared (i.e. the vector will have length zero)." So it is expected that these components will not contain the desired data.

Additional context

I'm using gz-sim8 on Ubuntu 24.04.

@mogumbo mogumbo added the enhancement New feature or request label Nov 1, 2024
@azeey azeey added good first issue Good for newcomers help wanted We accept pull requests! labels Jan 6, 2025
@azeey
Copy link
Contributor

azeey commented Jan 6, 2025

We'll need to add components to record the current limits obtained from the physics engine.

@azeey azeey moved this from Inbox to To do in Core development Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted We accept pull requests!
Projects
Status: To do
Development

No branches or pull requests

2 participants