From f15e825e2e370cd7478eb40788e345b25d0fc3d8 Mon Sep 17 00:00:00 2001 From: Justin Kambic Date: Wed, 11 Sep 2024 09:36:26 -0400 Subject: [PATCH] [Synthetics] Unskip and fix Synthetics global params e2e tests (#192400) ## Summary Goal is to unskip the test suite for global params in Synthetics e2e. --- .../journeys/global_parameters.journey.ts | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/global_parameters.journey.ts b/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/global_parameters.journey.ts index 587806e136937..831f8d107f36a 100644 --- a/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/global_parameters.journey.ts +++ b/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/global_parameters.journey.ts @@ -10,12 +10,7 @@ import { byTestId } from '../../helpers/utils'; import { cleanTestParams } from './services/add_monitor'; import { syntheticsAppPageProvider } from '../page_objects/synthetics_app'; -const journeySkip = - (...params: Parameters) => - () => - journey(...params); -// See details: https://github.com/elastic/kibana/issues/191961 -journeySkip(`GlobalParameters`, async ({ page, params }) => { +journey(`GlobalParameters`, async ({ page, params }) => { const syntheticsApp = syntheticsAppPageProvider({ page, kibanaUrl: params.kibanaUrl, params }); before(async () => { @@ -64,7 +59,7 @@ journeySkip(`GlobalParameters`, async ({ page, params }) => { await page.click('[placeholder="Search..."]'); await page.fill('[placeholder="Search..."]', 'username'); await page.click('text=username'); - await page.click('[aria-label="Clear input"]'); + await page.click('[aria-label="Clear search input"]'); await page.click('[placeholder="Search..."]'); await page.fill('[placeholder="Search..."]', 'website'); await page.click('text=website username'); @@ -74,7 +69,7 @@ journeySkip(`GlobalParameters`, async ({ page, params }) => { await page.fill('[placeholder="Search..."]', 'extra'); await page.keyboard.press('Enter'); await page.click('text=No items found'); - await page.click('[aria-label="Clear input"]'); + await page.click('[aria-label="Clear search input"]'); }); step('Click text=Delete ParameterEdit Parameter >> :nth-match(button, 2)', async () => { @@ -91,7 +86,7 @@ journeySkip(`GlobalParameters`, async ({ page, params }) => { await page.click('text=staging'); await page.click('button:has-text("Tags")'); await page.click('[aria-label="Tags"] >> text=staging'); - await page.click('[aria-label="Clear input"]'); + await page.click('[aria-label="Clear search input"]'); }); step('Click text=Delete ParameterEdit Parameter >> button', async () => { await page.click('text=Delete ParameterEdit Parameter >> button');