You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My proposal is not addressed by the documentation or examples
Existing issues
Nothing similar appears in an existing issue
What problem does your feature proposal solve?
There are several hundreds of thousands edges with implicit maxspeed value like "RO:urban". It'd be helpful to convert those string values to numbers in order to get the most accurate maxspeeds as well as travel times.
What is your proposed solution?
Scrape maxspeed mapping from wiki, put the mapping somewhere in config so users could override values as they see fit, like with other config values: ox.settings.implicit_maxspeed_values["AR:rural"]=200 for example.
In _clean_maxspeed function try to safely get value from the mapping if parsing as number failed.
What alternatives have you considered?
Don't put whole mapping in config, accept new parameter with this mapping in add_edge_speeds so users provide it themselves, but I think that keeping it with all default values in settings would result in a better out of the box experience for users.
Additional context
Taginfo link for maxspeed values.
Related PR #1153
The text was updated successfully, but these errors were encountered:
Contributing guidelines
Documentation
Existing issues
What problem does your feature proposal solve?
There are several hundreds of thousands edges with implicit maxspeed value like
"RO:urban"
. It'd be helpful to convert those string values to numbers in order to get the most accurate maxspeeds as well as travel times.What is your proposed solution?
Scrape maxspeed mapping from wiki, put the mapping somewhere in config so users could override values as they see fit, like with other config values:
ox.settings.implicit_maxspeed_values["AR:rural"]=200
for example.In
_clean_maxspeed
function try to safely get value from the mapping if parsing as number failed.What alternatives have you considered?
Don't put whole mapping in config, accept new parameter with this mapping in
add_edge_speeds
so users provide it themselves, but I think that keeping it with all default values insettings
would result in a better out of the box experience for users.Additional context
Taginfo link for maxspeed values.
Related PR #1153
The text was updated successfully, but these errors were encountered: