Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad 2d profile when extracting 1d #45

Open
ivolabbe opened this issue Aug 22, 2023 · 2 comments
Open

bad 2d profile when extracting 1d #45

ivolabbe opened this issue Aug 22, 2023 · 2 comments

Comments

@ivolabbe
Copy link

ivolabbe commented Aug 22, 2023

msaexp seems to produce corrupted 2D profiles in utils.make_optimal_extraction

This generates 'phantom' emission lines in 1D where the 2D looks fine

This happens at low SNR, so is a different bug from the previous masking bug

importlib.reload(msaexp)
importlib.reload(drizzle)

hdul = fits.open('uncover_2561_msa2-10646-prism-clear.d2d.fits')
prf_fwhm = 1.9
outhdu = msaexp.drizzle.extract_from_hdul(hdul,
                                              prf_sigma=prf_fwhm/2.35, fix_sigma=False,
                                              prf_center=None, fix_center=False,
                                              verbose=True, fit_prf=True,
                                              )


hdul.info()
sci2d = outhdu['SCI'].data
prf2d = outhdu['PROFILE'].data
wht2d = outhdu['WHT'].data
plt.imshow(prf2d,interpolation='nearest')

download-1

@gbrammer
Copy link
Owner

I think this should also be addressed with 9baaed0 in version > 0.6.15.

@gbrammer
Copy link
Owner

Related discussion at #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants