You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There have been issues in the past when either an existing container was renamed, or a new service was added accidentally with the same name as an existing container.
In the former case, the container with the previous name will continue to run and cause issues with the proxy.
In the latter case, there are now two containers running with the same name, also causing proxy and other issues. And after fixing this (= renaming the new container), we will have the former case, where the previous container is still running.
I would like to implement two fixes:
Refuse to start a service that has the same container name as an existing service.
Stop and remove orphaned containers (i.e. previous containers that we renamed and restarted under a new name).
This should prevent most issues of having to manually fiddle with Docker commands.
The text was updated successfully, but these errors were encountered:
Orphaned containers are now removed on start/restart.
Currently, it will still allow duplicate service names to exist, but 1) I added a check script in ./src/check.ts which checks for this specifically, and 2) this check script is now run in GitHub Actions and will fail if there are duplicates. (Ideally, you'd check this before committing though.)
I will leave this issue open because further improvements would be good.
There have been issues in the past when either an existing container was renamed, or a new service was added accidentally with the same name as an existing container.
In the former case, the container with the previous name will continue to run and cause issues with the proxy.
In the latter case, there are now two containers running with the same name, also causing proxy and other issues. And after fixing this (= renaming the new container), we will have the former case, where the previous container is still running.
I would like to implement two fixes:
This should prevent most issues of having to manually fiddle with Docker commands.
The text was updated successfully, but these errors were encountered: