Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AMB schema and URL #79

Open
acka47 opened this issue Oct 23, 2023 · 0 comments
Open

Update AMB schema and URL #79

acka47 opened this issue Oct 23, 2023 · 0 comments
Assignees

Comments

@acka47
Copy link

acka47 commented Oct 23, 2023

Hi @nichtich, we have published the first official version of AMB, see https://dini-ag-kim.github.io/amb/latest/. Going through the remaining AMB issues, I stumbled over dini-ag-kim/amb#150 and had a look at the validation service.

I noticed two things:

  1. The used draft schema seems to be cached by the application and the breaking change in dini-ag-kim/amb@d785187 isn't taken into account. Thus, valid resources do not validate correctly, see e.g. http://format.gbv.de/validate/validate?format=amb&data=&url=https%3A%2F%2Fgithub.com%2Fdini-ag-kim%2Famb%2Fraw%2Fmain%2F20231019%2Fexamples%2Fvalid%2FlearningResourceType.json
  2. The schema URL needs to be updated. You could point to the latest schema by using https://dini-ag-kim.github.io/amb/latest/schemas/schema.json. I noticed that the service also supports versioning so you might also add that.

I tried to make a PR but the data apparently is not in the repo. Is there any way to provide a fix for such a problem by myself?

@nichtich nichtich self-assigned this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants