Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take cached kernel_mean_row_sum in Refine #264

Closed
tp832944 opened this issue Nov 30, 2023 · 0 comments · Fixed by #266
Closed

Take cached kernel_mean_row_sum in Refine #264

tp832944 opened this issue Nov 30, 2023 · 0 comments · Fixed by #266
Assignees
@bk958178

Comments

@tp832944
Copy link
Contributor

tp832944 commented Nov 30, 2023 •
edited
Loading

Refine.refine() currently calculates kernel_mean_row_sum with no option to use an already-calculated value. Add this as an optional argument to the refine(), taking a default value of None to indicate that it still needs to be calculated. Document that Refine.approximate_kernel_row_sum will be ignored if kernel_mean_row_sum is passed.

This is necessary for OOPing of kernel herding refine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bk958178 bk958178

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/take optional kernel_mean_row_sum in refine() gchq/coreax
2 participants
@tp832944 @bk958178