Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fishbowl generated code is not compliant with PEP8 #49

Closed
GCHQDeveloper314 opened this issue May 16, 2024 · 1 comment · Fixed by #57
Closed

Fishbowl generated code is not compliant with PEP8 #49

GCHQDeveloper314 opened this issue May 16, 2024 · 1 comment · Fixed by #57
Assignees
@GCHQDeveloper314
Labels
automation bug Something isn't working

Comments

@GCHQDeveloper314
Copy link
Member

The Python code generated by fishbowl is not PEP8 compliant and this causes a PEP8 change to be required every time the Gaffer version is upgraded.

This problem relates to Python imports and can be seen here.
@GCHQDeveloper314 GCHQDeveloper314 added bug Something isn't working automation labels May 16, 2024
@GCHQDeveloper314
Copy link
Member Author

GCHQDeveloper314 commented Sep 20, 2024 •
edited
Loading

This problem was caused by changes in #44 where a space was removed because it was potentially considered to be a typo.

@GCHQDeveloper314 GCHQDeveloper314 mentioned this issue Sep 20, 2024
Merged
@GCHQDeveloper314 GCHQDeveloper314 linked a pull request Sep 20, 2024 that will close this issue
Gh-29: Fishbowl should correctly set copyright dates #57
Merged
@GCHQDeveloper314 GCHQDeveloper314 self-assigned this Sep 20, 2024
@j69772 j69772 closed this as completed in 1eff374 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GCHQDeveloper314 GCHQDeveloper314

Labels
automation bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gh-29: Fishbowl should correctly set copyright dates gchq/gafferpy
1 participant
@GCHQDeveloper314