Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop invoking table batching lambdas in system tests #2003

Closed
patchwork01 opened this issue Mar 12, 2024 · 1 comment
Closed

Stop invoking table batching lambdas in system tests #2003

patchwork01 opened this issue Mar 12, 2024 · 1 comment

Comments

@patchwork01
Copy link
Collaborator

patchwork01 commented Mar 12, 2024

Background

Split from:

Child issue of:

Related to:

We'd like to be able to run system tests in parallel. Each system test runs in its own Sleeper table, but right now several operations are done across all tables at once. This means eg. garbage collection will affect all running system tests when it's invoked.

Description

In order to isolate system tests from one another when they run in parallel in the same instance, we'd like to change the places where system tests currently invoke table batching lambdas.

Instead of invoking the table batching lambdas, we can match the implementation of the lambdas, but instead of batching over all the tables (or all the online tables), we can batch over the tables that are active in the current test, with SystemTestInstanceContext.streamTableProperties.

Analysis

Here are the relevant operations:

  • Compaction job creation
  • Partition splitting
  • Garbage collection
  • Table metrics

We've split out a separate issue to convert the multiple tables test to run in its own instance, and switch it back to invoke the table batching lambdas:

We could make sure we keep the code to invoke the table batching lambdas around, so that we can use it for that.

We did some work on this here, which we could reuse:

@patchwork01 patchwork01 added this to the 0.22.0 milestone Mar 12, 2024
@patchwork01 patchwork01 changed the title Stop invoking table batching lambdas in most system tests Stop invoking table batching lambdas in system tests Mar 13, 2024
@patchwork01 patchwork01 removed this from the 0.22.0 milestone Mar 13, 2024
@patchwork01
Copy link
Collaborator Author

patchwork01 commented Nov 22, 2024

The following issue replaces this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant