Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log view is slow #56

Open
GoogleCodeExporter opened this issue Oct 21, 2015 · 7 comments
Open

Log view is slow #56

GoogleCodeExporter opened this issue Oct 21, 2015 · 7 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Load a revision history, ex: 
https://chromium.googlesource.com/chromium/src/+log/master/chrome/browser/safe_b
rowsing/safe_browsing_service.h
or 
https://chromium.googlesource.com/chromium/src/+log/master/third_party/hwcplus/i
nclude/cutils/log.h

What is the expected output? 
Page loads quickly, within a few seconds at most.

What do you see instead?
Takes about 60 seconds for a file with a reasonable history, and even still 
over 30 seconds for a file with only one revision.


Please provide any additional information below.

From 
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/500gTr9xVf8:
"The gerrit team has mentioned that they might be able to leverage the blame 
cache for the purpose of generating the log view, but I don't think they have 
done any work on it."

Original issue reported on code.google.com by [email protected] on 18 Jun 2014 at 11:12

@GoogleCodeExporter
Copy link
Author

I'm not sure what you mean by a "reasonable history".

$ time git log --oneline master -- 
chrome/browser/safe_browsing/safe_browsing_service.h | wc -l
134
git log --oneline master --   7.72s user 0.17s system 99% cpu 7.927 total
wc -l  0.00s user 0.00s system 0% cpu 7.927 total

That's on my reasonably fast workstation with a hot disk cache. Unfortunately 
googlesource.com slowdowns of 2x-10x are par for the course on _every_ git 
operation. It just happens that many git operations are so fast you don't 
notice.

We've put substantial effort into caching blame results but have done nothing 
for file logs. Don't mind leaving this bug open but this is not currently on 
our roadmap.

Original comment by [email protected] on 18 Jun 2014 at 11:20

@GoogleCodeExporter
Copy link
Author

Issue 57 has been merged into this issue.

Original comment by [email protected] on 18 Jun 2014 at 11:33

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 19 Jun 2014 at 11:23

@GoogleCodeExporter
Copy link
Author

hmm, this is something that I use more than blame. It's critical that this is 
fast, since we need to use this often during our day to track down regressions 
and other tasks. I haven't tried to use it on gitiles since I had presumed it 
would be fast.

@dborowitz: by "reasonable", we're comparing it to viewvc.

Original comment by [email protected] on 27 Jun 2014 at 2:58

@GoogleCodeExporter
Copy link
Author

+1 to this being a major part of Chromium development workflow.

Original comment by [email protected] on 27 Jun 2014 at 5:15

@GoogleCodeExporter
Copy link
Author

https://gerrit-review.googlesource.com/58913 is a bandaid until we can work 
through the necessary core changes to git to improve log of a file.

Original comment by [email protected] on 31 Jul 2014 at 6:30

@GoogleCodeExporter
Copy link
Author

We have integrated git into a wiki-style transcription editing system, and when 
the user wishes to see the history log for the transcriptions, it can take 
minutes to pull up the log.  Would really appreciate this being moved up in 
priority.

Original comment by [email protected] on 7 Oct 2014 at 2:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant