Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies; use latest libraries where possible #5

Open
PaulBoon opened this issue Jun 27, 2023 · 5 comments
Open

Upgrade dependencies; use latest libraries where possible #5

PaulBoon opened this issue Jun 27, 2023 · 5 comments

Comments

@PaulBoon
Copy link
Collaborator

If we don't upgrade we potentially miss out on improvements and important fixes.

Currently the following libs are used:

  • jquery 3.5.1
  • JqTree 1.4.12
  • bootstrap 3.3.7
  • d3plus 1.9.1

The latest (at time of writing) are:

  • jquery 3.7.0
  • jqTree 1.7.0
  • bootstrap 5.3
  • d3plus 2.1.1
@PaulBoon
Copy link
Collaborator Author

PaulBoon commented Jun 30, 2023

Upgrade of jquery was simple, replacing with 3.7.0 seemed to work 'out-of-the-box'.

    <script src="https://code.jquery.com/jquery-3.7.0.min.js">
    </script>

However, Bootstrap did not go as well. Versions 5.x and 4.x seem to give problems with our use of the gridlayout. This should be investigated.

Upgrading to the latest 3.x; 3.4.1. did work.

<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css" integrity="sha384-HSMxcRTRxnN+Bdg0JdbxYKrThecOKuH5zCYotlSAcp1+c8xmyTe9GYg1l9a69psu" crossorigin="anonymous">
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.min.js" integrity="sha384-aJ21OjlMXNL5UyIl/XNwTMqvzeRMZH2w8c5cRVpzpU8Y5bApTppSuUkhZXN0VxHd" crossorigin="anonymous"></script>

@PaulBoon
Copy link
Collaborator Author

PaulBoon commented Jul 4, 2023

JQTree 1.7.0, from https://mbraak.github.io/jqTree was working fine. Did also move that to a version specific directory.

    <script src="jqtree.1.7.0/tree.jquery.js">
    </script>

and

    <link href="jqtree.1.7.0/jqtree.css" media="screen" rel="stylesheet" type="text/css">

Removed the bottom line of the js file, referencing the 'map', only used for debuggin.

@PaulBoon
Copy link
Collaborator Author

PaulBoon commented Jul 4, 2023

First attempt to upgrade d3plus has not been successful. Seems that the change from v1 top v2 needs a considerable rewrite. We already use the latest 1.x version; 1.9.8. We might consider to keep it for a while.
BTW I tried using these:

<script src="https://cdnjs.cloudflare.com/ajax/libs/d3/7.8.5/d3.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/d3plus/2.1.1/d3plus.min.js"></script>

@PaulBoon
Copy link
Collaborator Author

PaulBoon commented Jul 5, 2023

Upgrading to bootstrap 5.3.0 was not simple, a lot changed; cards instead of panels, no glypicons and collaps was different.
This page was helpful: https://getbootstrap.com/docs/4.0/migration/

@PaulBoon
Copy link
Collaborator Author

PaulBoon commented Jul 5, 2023

The d3plus upgrading/migration is diificult, because of lack of documentation and examples that are usefull.
Upgrading was an issue before: IQSS/dataverse-metrics#69

Looks like we could have a separate PR for just the d3plus upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant