Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tell users to renew their API tokens #14

Open
donsizemore opened this issue Apr 14, 2023 · 2 comments
Open

tell users to renew their API tokens #14

donsizemore opened this issue Apr 14, 2023 · 2 comments

Comments

@donsizemore
Copy link
Member

Just tried dv-webloader on a 5.13 test system. Visually the screen hangs, telling me: Getting Dataset Information...

Javascript console sez 401 Unauthorized

Payara log sez attempted access with expired token

It would be user-friendly to percolate this last error back to the browser.

@luddaniel
Copy link
Contributor

This issue has been fixed with IQSS/dataverse@85fc67d with getWebloaderUrlForDataset(Dataset d) asking for getValidApiTokenForUser(AuthenticatedUser user) that handles both cases : having no key and an expired key.

Tested on Dataverse 5.14

@pdurbin
Copy link
Member

pdurbin commented Sep 6, 2023

@luddaniel interesting. Thanks.

That commit is part of #9096 which made it into Dataverse 5.13 so I'm not sure why @donsizemore saw this bug, since he was testing 5.13.

@donsizemore maybe when you get a chance, you can re-test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants