Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit after successful file upload #8

Open
philippconzett opened this issue Oct 6, 2022 · 3 comments · May be fixed by #22
Open

Exit after successful file upload #8

philippconzett opened this issue Oct 6, 2022 · 3 comments · May be fixed by #22

Comments

@philippconzett
Copy link

I have been able to upload several ~5 GB files organized in several folders. However, I'm not sure how to proceed after successful file upload:

  1. Maybe some instructions could be added, e.g., "You may now close this web browser tab" (or similar).

  2. When refreshing the dataset landing page one needs to confirm the following message:
    image

But after clicking the Continue button, a new DVWebloader tab is opened.

To see the uploaded file, I actually had to close the tab with the dataset landing page also, and then click into the dataset from the repository/collection landing page once more.

Depending on how this tool/feature is further developed, the comments above are possible irrelevant.

I guess the idea is that folder/file upload as now implemented in DVWebloader would be implemented so that a Dataverse installation admin could configure this kind of upload as the default, and depositors would simply click the usual upload button to upload folders/files this way. Another side is download. Will it work along the same lines? Maybe we can discuss further progress on email or a call. Thanks!
@qqmyers
Copy link
Member

qqmyers commented Oct 6, 2022

The form resubmission is general to at least dataset external tools, so a separate issue and something that goes away if/when this isn't a tool.

Having more progress/completion info and then a note to close the window and return to the dataset makes sense.

I don't think this should get swapped in as the default upload (you can't actually upload just one file with this unless it is alone in a folder) but it could be an option like DropBox/Globus. Time/interest permitting, any/all of those could potentially show up in the same Dataset window rather than as a separate tab.

W.r.t. next steps - a call or email, or a google doc, makes sense - basically getting a prioritized list of changes together would help.

@philippconzett
Copy link
Author

Thanks! I'have created a Google doc and will share the link via email.

@qqmyers
Copy link
Member

qqmyers commented Nov 9, 2022

The code now shows a success message that indicate you should close the window and refresh the dataset window to see the uploads.

luddaniel added a commit to Recherche-Data-Gouv/dvwebloader that referenced this issue Sep 6, 2023
@luddaniel
gdcc#8 adding link to dataset on success and handling parameters in l…
b7c2b39 
…anguage keys
@luddaniel luddaniel linked a pull request Sep 6, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@qqmyers @philippconzett