Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of Hive over SharedPreferences; make the Alarm class abstract and final, or singleton #210

Open
ShadichyDev opened this issue Jun 6, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request needs author feedback Further information or answer is requested by author

Comments

@ShadichyDev
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Hive is much more efficient and strictly typed than SharedPreferences. You should consider moving to Hive
Also, the Alarm class sometimes confuses me with the (). Simple workaround is to make it 'abstract final', or make it singleton class

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@ShadichyDev ShadichyDev added the enhancement New feature or request label Jun 6, 2024
@gdelataillade
Copy link
Owner

Hi @ShadichyDev

I use hive in my other projects and I think the package is awesome but I chose shared_preferences for the following reasons:

  • more efficient for smaller datasets
  • uses native iOS/Android APIs, so useful if one day I need to access data from native code
  • uses less dependencies

I'm open to discussion, and if you change my mind I will do the migration.

@gdelataillade gdelataillade added the needs author feedback Further information or answer is requested by author label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs author feedback Further information or answer is requested by author
Projects
None yet
Development

No branches or pull requests

2 participants