Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

middleware.auth roles don't work #105

Open
Splaktar opened this issue Mar 12, 2017 · 1 comment
Open

middleware.auth roles don't work #105

Splaktar opened this issue Mar 12, 2017 · 1 comment
Labels
Milestone

Comments

@Splaktar
Copy link
Contributor

Splaktar commented Mar 12, 2017

For example the tag update endpoint says that it requires admin role, but even when I'm not logged in and all cookies/cache is cleared, I can still modify the tag.

  app.route('put', '/tags/:tagId', {
      summary: 'Updates a single tag, requires admin role'
    },
    middleware.auth({roles: ['admin']})

This needs to be resolved before we can add more functionality to the Hub in regards to editing anything (chapters, events, tags, etc).

This is related to PR #53.

@Splaktar Splaktar added the bug label Mar 12, 2017
@Splaktar Splaktar added this to the v0.2.1 milestone Mar 12, 2017
@Splaktar
Copy link
Contributor Author

It might be possible to solve this by using Cloud Endpoints (#99) with Firebase Auth instead of middleware.auth.

@Splaktar Splaktar modified the milestones: v0.3.0, v0.2.1 Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant