Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "tags" to cell decorator #425

Closed
tvt173 opened this issue Jul 17, 2024 · 2 comments · Fixed by #496
Closed

Add "tags" to cell decorator #425

tvt173 opened this issue Jul 17, 2024 · 2 comments · Fixed by #496
Labels
enhancement New feature or request

Comments

@tvt173
Copy link
Collaborator

tvt173 commented Jul 17, 2024

Depending on the user or context, it may be useful to organize cells in a particular way. For example:

  1. Actives vs passives (or maybe electrical, optical, or electro-optical)
  2. golden vs experimental cells (or whatever maturity levels the organization might have)
  3. Functional groups, like splitters, routing elements, modulators, etc.

A nice way to do this might be to allow the specification of "tags" or "labels" on the component, within the cell decorator, so that they can be obtained without needing to invoke the component. Then the user could specify a set of tags for any given component, letting the downstream user of the library filter or organize as they please.

These tags could be simple like "splitter" or you could specify something like "maturity:golden" that gives the user a way to filter and select from a subcategory of tags.

For example, a component definition might look like this:

@cell(tags=["type:electro-optical", "group:modulators", "maturity:golden"])
def eam():
    # ...
    return component

@sebastian-goeldi @joamatab @flaport

@tvt173 tvt173 added the enhancement New feature or request label Jul 17, 2024
@sebastian-goeldi
Copy link
Collaborator

sebastian-goeldi commented Jul 17, 2024

Sure sounds reasonable. Where do you want to retrieve them from by tag? kcl.factories?

And maybe it makes sense to have the tags be a dict instead?

@tvt173
Copy link
Collaborator Author

tvt173 commented Jul 17, 2024

could be, if the tags will always be grouped like this, and there will always be one tag per group. i thought it might be more flexible this way though.

@sebastian-goeldi sebastian-goeldi linked a pull request Oct 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants