Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(erc20-manager): Replace tx.origin with msg.sender #219

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(erc20-manager): Replace tx.origin with msg.sender #219

wants to merge 2 commits into from

Conversation

mertwole
Copy link
Member

@mertwole mertwole commented Nov 28, 2024 •
edited
Loading

Resolves #193

Breaking frontend: now approve should be made for the BridgingPayment address when requesting transfer from Ethereum to Gear

@LouiseMedova LouiseMedova self-requested a review November 29, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouiseMedova LouiseMedova LouiseMedova approved these changes

Assignees
No one assigned
Labels
breaking dontmerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of tx.origin in ERC20Manager
2 participants
@mertwole @LouiseMedova