Skip to content
This repository has been archived by the owner on Jun 26, 2022. It is now read-only.

'Add Bookmark' does not work until 'Bookmarks' are viewed once. #5

Open
geekodour opened this issue Sep 11, 2018 · 5 comments
Open
Labels
bug Something isn't working hackoctoberfest help wanted Extra attention is needed

Comments

@geekodour
Copy link
Owner

This happens because to 'Bookmark' a tweet, we need the user creds and these credentials are fetched when the 'Bookmarks' button is clicked on the navbar.

So, it will work only after you click the 'Bookmarks' on the navbar once and then close the modal.

@geekodour geekodour added bug Something isn't working help wanted Extra attention is needed labels Sep 11, 2018
@geekodour
Copy link
Owner Author

Probably a note in a README.md for now would be a temporary fix.

@battez
Copy link

battez commented May 1, 2019

hi for me on Chrome (downloaded & unpacked, installed ext) this Bookmarks link does nothing when I click from twitter.com . Nor does the Add Bookmark link in the tweet modal. But they do show.

Is it maybe better to have the Bookmarks Link you have done link to mobile.twitter.com/i/bookmarks ?

It is weird that Twitter does not allow via API the Bookmarking. Just been looking into this and found your extension. I do not have Firefox but will try it in that later! Cheers.

@geekodour
Copy link
Owner Author

@battez the new desktop twitter UI comes with native bookmarks! I suggest you try the new UI (it looks bad but I got used to it now ;) ) thanks for trying my extension :)

@battez
Copy link

battez commented May 6, 2019

@geekodour hi yes I saw that but it hasn't rolled out to me seemingly (?) - I am in UK. Yes, I discovered your extension a bit late, I am just getting interested in chrome-ff ext dev.

@battez
Copy link

battez commented May 6, 2019

sweet! realised on Profile > link to Try New Twitter and now I have bookmarks, awesome, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working hackoctoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants